search

terminus-plugin-project / terminus-pancakes-plugin

Terminus Plugin to open Pantheon Site Databases in your Favorite SQL Client
MIT License
26 stars 20 forks source link

Terminus 3.0 compatibility #31

Closed jeffm2001 closed 2 years ago

jeffm2001 commented 2 years ago

When the plugin is installed with the terminus 3 command (terminus self:plugin:install terminus-plugin-project/terminus-pancakes-plugin), every subsequent terminus command generates multiple PHP warnings:

PHP Warning:  include(/Users/jmann/.terminus/terminus-dependencies-2512c16/vendor/terminus-plugin-project/terminus-pancakes-plugin/src/Commands/../../vendor/autoload.php): failed to open stream: No such file or directory in /Users/jmann/.terminus/terminus-dependencies-2512c16/vendor/terminus-plugin-project/terminus-pancakes-plugin/src/Commands/PancakesCommand.php on line 13

The plugin still works as expected without this include statement, so I propose simply removing it.

greg-1-anderson commented 2 years ago

I'm guessing that this was included for Terminus 1 (or Terminus 0?) compatibility. It would be best to remove it now, as those old Terminus versions are no longer supported on the Pantheon platform.

uberhacker commented 2 years ago

@jeffm2001: Good call! Thank you for the confirmation @greg-1-anderson.