search

terminusdb-labs / swipl-rs

25 stars 6 forks source link

Upgrade bindgen and remove clippy warnings #42

Closed matko closed 1 year ago

matko commented 1 year ago

We were using an older version of bindgen which was generating code with loads of warnings in newer versions of rust. The new version generates better code, but also generates slightly different types which required various fixes.

As a bonus, all clippy warnings have been resolved too, including in macro expansions.

matko commented 1 year ago

Converting to draft as older versions of swipl will no longer build with this and i'd like to maintain some compatibility.

matko commented 1 year ago

undrafting cause apparently the bug is not new. Reported as #43.

matko commented 1 year ago

We probably want to add clippy to this project though @rrooij