terminusdb / terminus-dashboard

Management Dashboard for Terminus DB
Apache License 2.0
16 stars 2 forks source link

Improve style using responsive design and a framework #15

Open spl opened 4 years ago

spl commented 4 years ago

I've been playing with TerminusDB, and I started looking at fixing a few minor issues around padding and margin, but then I discovered the top-level layout is done with HTML tables. This makes it difficult to work with the dashboard on smaller displays such as mobile phones and tablets (or even just resizing the browser window to half of the desktop).

Would you be interested in accepting some improvements to the dashboard style? I think there are two that would make the most difference:

  1. Responsive design to support different sized displays.
  2. Using a front-end framework to both simplify the implementation of the above and avoid having a lot of the custom CSS that appears in src/css.

I would first consider Bootstrap for the framework, since it is one of the best-known, well-documented, and longest-maintained options. But there are plenty of other options out there if you have a preference.

KittyJose commented 4 years ago

Hi Sean, Thanks very much for the feedback... We have considered this and are working towards using responsive design to support the dashboard. The initial use of the dashboard were to use APIs and so on ... now we are planning to improvise this and change the styles.

We very much appreciate your thoughts please feel free to provide more feedback and comments :)

spl commented 4 years ago

@KittyJose Thanks for the response. I'm glad to see responsive design is on your roadmap.

I was thinking about looking into it myself, but it sounds like you are already doing so. Is that correct?

KittyJose commented 4 years ago

Hi Sean,

Thanks for your response, yes responsive design is part of our roadmap (already started work on it)... Yes, feel free to look into it and let us know about your thoughts or prototype or code or whatever it is and we can collaborate further?

Thanks very much,

On Wed, Jan 29, 2020 at 7:45 AM Sean Leather notifications@github.com wrote:

@KittyJose https://github.com/KittyJose Thanks for the response. I'm glad to see responsive design is on your roadmap.

I was thinking about looking into it myself, but it sounds like you are already doing so. Is that correct?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/terminusdb/terminus-dashboard/issues/15?email_source=notifications&email_token=AM4ZRL6J6ZPVQW3JR3HUWYTRAEXYRA5CNFSM4KMQQ2G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKGIMKA#issuecomment-579634728, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM4ZRLYRQARBLXR4ZI6PAGLRAEXYRANCNFSM4KMQQ2GQ .

-- Thanks, Kitty

kynrai commented 4 years ago

Hello, Just using the dashboard as part of the London workshop. Noticed a few quick wins, although if you are going to use a web framework to rebuild it I don't know if its worth it.

Styles render inconsistently across browsers. I added the standard normalize.css and it fixed it.

The main container does not resize correctly on small screens as it appears to have a minimum height.

KittyJose commented 4 years ago

Hello Steven,

Glad to hear you have received few quick wins :) we are using react for responsive design and should be ready very soon... what do you think?

On Tue, Feb 11, 2020 at 8:32 PM Steven Lee notifications@github.com wrote:

Hello, Just using the dashboard as part of the London workshop. Noticed a few quick wins, although if you are going to use a web framework to rebuild it I don't know if its worth it.

Styles render inconsistently across browsers. I added the standard normalize.css and it fixed it.

The main container does not resize correctly on small screens as it appears to have a minimum height.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/terminusdb/terminus-dashboard/issues/15?email_source=notifications&email_token=AM4ZRL47ALUF667E5BQKAQLRCMDPJA5CNFSM4KMQQ2G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELN6SMY#issuecomment-584837427, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM4ZRL74WZKLQML3KG23YVTRCMDPJANCNFSM4KMQQ2GQ .

-- Thanks, Kitty