termux / termux-api-package

Termux package containing scripts to call functionality in Termux:API.
MIT License
1.06k stars 324 forks source link

Bash shebang #34

Closed gafusss closed 6 years ago

gafusss commented 6 years ago

Hello!

I'm not sure whether this issue goes here or to termux-packages.

Some of the scripts here (e.g. termux-brightness) have a bash shebang. Bash package is not marked as essential in termux-packages, neither it is located in the bootstrap. This package does not depend on the bash package either.

Running such scripts from dash (which is, IIRC, the default shell, since it is "essential") produces an error.

I see two possible solutions to this problem:

UPD: I was wrong and bash is actually included in the bootstrap, and is actually used as a login shell. However, it is still possible to remove the bash package (which can be removed since termux-api does not depend on it), which makes some scripts (e.g. termux-dialog) unusable.

UPD2: termux-api now depends on bash, which is now also an essential package. Feel free to close this and the corresponding PR, if you feel that it is not necessary to remove the bash dependency