search

termux / termux-api-package

Termux package containing scripts to call functionality in Termux:API.
MIT License
1.02k stars 318 forks source link

Add --icon and --icon-list commands to termux-notification #98

Closed yurimataev closed 4 years ago

yurimataev commented 4 years ago

Related to termux/termux-api#343

termux-notification --icon <icon-name> will set the status bar icon to the named icon. termux-notification --icon-list shows the list of available icons.

xalexalex commented 4 years ago

Hey! Thanks for the great work!

Just one remark: I don't really like the huge list, both in source code and as the output of the command. I presume the icon names listed in --icon-list are the same that are available at https://material.io/resources/icons/, which the user will have to open anyway to actually see the icons, so I would suggest simply linking the website and removing --icon-list (see attached commit).

If, on the other hand, the icon list termux uses is different from that shown on the website (e.g. dashes - are _ underscores, or we only have a subset of icons) then we'll have to find the best way to inform the user. Perhaps some text as --help-icons or a wiki page.

Let me know what you think!

yurimataev commented 4 years ago

Yes, that sounds like a good idea. I used the complete collection of icons, and didn't change any names, so just referring the user to the website would work. It's my old habit to make sure all documentation is self-contained, but probably isn't so crucial in this case :)

I'll make the changes.

yurimataev commented 4 years ago

Never mind, I see that you have already done it. It looks good to me!