search

termux / termux-app

Termux - a terminal emulator application for Android OS extendible by variety of packages.
https://f-droid.org/en/packages/com.termux
Other
36.21k stars 3.81k forks source link

Style's background is black when opening the app after wake locking #1032

Closed ghost closed 5 years ago

ghost commented 5 years ago

Problem description I manually edited ~/.termux/colors.properties to apply a theme to Termux, after activating wake lock and closing all sessions. When I re-open the app, the background is black. (It also does the same using Termux:Style themes).

Steps to reproduce Apply styles to Termux with either Termux:Style or manually editing ~/.termux/colors.properties & termux-reload-settings. Choose a background colour that isn't black. Close all sessions from within Termux until it exits. Open the app, the background is black, not the colour you chose.

Expected behavior The background colour should stay the colour it was originally set to.

Additional information The colours are restored when opening a second session, or disabling wake lock, ans opening the app once again.

The theme I currently have: screenshot_20190212-205818_termux screenshot_20190212-205945_termux

Test theme: screenshot_20190212-210537_termux screenshot_20190212-210545_termux

ghost commented 5 years ago

Observed the same issue yesterday, thought it affects only me. Can be fixed in this way https://github.com/xeffyr/termux-app/commit/ef12842e7e2255e622cae40c3abc46320643593b - we just need to force-reload colors once new session started.

ghost commented 5 years ago

Oh wow. Only affects you, what device you got?

ghost commented 5 years ago

I use custom build of Termux application which has styling embedded. So I just didn't tested Termux:Styling well with original app.

Problem is that Termux app updates fonts or colors only on:

ghost commented 5 years ago

I opened a PR which fixes that.

ghost commented 5 years ago

Ah I see, nice.