search

termux / termux-app

Termux - a terminal emulator application for Android OS extendible by variety of packages.
https://f-droid.org/en/packages/com.termux
Other
36.86k stars 3.87k forks source link

Changed: Updated FileReceiverActivityTest to include empty & null strings for invalidUrls to cover corner cases #4220

Closed jasonjyu closed 4 weeks ago

jasonjyu commented 1 month ago

Added to FileReceiverActivityTest empty & null strings for invalidUrls to cover corner cases

jasonjyu commented 1 month ago

@agnostic-apollo, @fornwall, would you have some time to review my PR? Thanks.

agnostic-apollo commented 1 month ago

Fix commit message.

https://github.com/termux/termux-app#commit-messages-guidelines

jasonjyu commented 1 month ago

Fix commit message.

https://github.com/termux/termux-app#commit-messages-guidelines

Can do.

jasonjyu commented 1 month ago

@agnostic-apollo, does my latest commit message conform to the guidelines now?

jasonjyu commented 1 month ago

Fix commit message.

https://github.com/termux/termux-app#commit-messages-guidelines

I fixed my commit message. Thanks.

agnostic-apollo commented 4 weeks ago

Fixed and merged. Thanks.

agnostic-apollo commented 4 weeks ago

Did you not bother running the tests to see if they actually passed?