search

termux / termux-float

Termux add-on app to show the terminal in a floating terminal window.
https://f-droid.org/en/packages/com.termux.window
Other
484 stars 76 forks source link

Update TermuxFloatService.java #25

Closed gewyvoso closed 4 years ago

ghost commented 4 years ago

Sorry but this PR isn't acceptable because it introduces an issue: a window doesn't appear on the first tap. See https://imgur.com/a/y3ffNjh.

I understand that you are trying to make it possible to hide a window, however that feature is already implemented through notification. Just tap on it and window will be hidden.

gewyvoso commented 4 years ago

sorry to waste your time with my imperfect code; and thank you for assessing my pr. i will be resubmitting after getting it right