search

termux / termux-float

Termux add-on app to show the terminal in a floating terminal window.
https://f-droid.org/en/packages/com.termux.window
Other
465 stars 77 forks source link

Update gradle plugin to version 4.1.3 to be in "sync" with termux-app project. #32

Closed edupsousa closed 3 years ago

edupsousa commented 3 years ago

The project termux-app currently uses gradle-plugin version 4.1.3, and termux-float uses 4.0.0.

This version mismatch leads to slightly different build environments and the need to download different Android NDK versions (~1GB each) to build each project.

Bumping gradle plugin version from 4.0.0 to 4.1.3 avoids those different build environments (and the NDK download) and as far as I tested doesn't break the build.

ghost commented 3 years ago

Gradle plugin unlikely to cause download different NDK, but dependencies can do this.

Termux has recently bumped its NDK version (https://github.com/termux/termux-app/blob/master/gradle.properties#L23) and released com.termux:terminal-view v0.112. Termux float uses older variant of com.termux:terminal-view which is v0.106 only. That's why different NDK is downloaded.

Bumping gradle plugin version from 4.0.0 to 4.1.3 avoids those different build environments (and the NDK download)

Probably because NDK already was installed (that's a "side-by-side" installation which allows multiple versions).

edupsousa commented 3 years ago

I noticed the issue I described after a clean Android Studio install.

I opened termux-app and received a complaint about the NDK installation during the gradle sync, installed it.

Then when I opened the termux-float the IDE complained about another NDK version missing, I bumped the version, did a sync and the build worked without complaints. So I thought it was the cause, but maybe it's something related with Android Studio.

Thanks

Em qui., 6 de mai. de 2021 18:10, Leonid Pliushch @.***> escreveu:

Gradle plugin unlikely to cause download different NDK, but dependencies can do this.

Termux has recently bumped its NDK version ( https://github.com/termux/termux-app/blob/master/gradle.properties#L23) and released com.termux:terminal-view v0.112. Termux float uses older variant of com.termux:terminal-view which is v0.106 only. That's why different NDK is downloaded.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/termux/termux-float/pull/32#issuecomment-833868927, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACKQOE7BU4LZ7RQZUGYUJ2DTMMAT5ANCNFSM44HVVNXA .