Minor Float bubble fixes

termux / termux-float

Termux add-on app to show the terminal in a floating terminal window.

https://f-droid.org/en/packages/com.termux.window

Other

484 stars 76 forks source link

Minor Float bubble fixes #38

Closed dkramer95 closed 3 years ago

dkramer95 commented 3 years ago

Fixed: Use dp instead of px so bubble size should now be consistent across devices.
Fixed: Some change in https://github.com/termux/termux-float/commit/90f908d0a02ec37cb2593d7fb1216c09ad60780f caused the outline to be cut off when in bubble mode but now displays properly.
- Removed round_button.xml drawable as no longer needed

dkramer95 commented 3 years ago

@agnostic-apollo Apart from the cutoff outline (which I have fixed), the latest changes on master looked good.

agnostic-apollo commented 3 years ago

I have removed unneeded copying of ViewUtils. The termux-shared library is already a dependency so can use it directly.

As for bubble size, it has now increased in size on my LG G5. 60dp is better for me. Did you increase it deliberately or is it the same size with the new change on your phone(s)?

Thanks for checking the rest.

dkramer95 commented 3 years ago

The size was same for me. This is what it looks like on my device with some other regular icons for scale.

(It probably increased in size now that it is using dp. Same thing happened when I tested on S7.. That's when I noticed issue because S7 initially was displaying smaller than my other devices... This should probably be a customizable option as well as users may want bubble smaller or larger)

agnostic-apollo commented 3 years ago

Yeah, see its bigger than your normal icons. Point of floating button is to be small so that its not intrusive to other apps. Try 60dp yourself and compare with an app that has a chat head like messenger. Android's FloatingActionButton.SIZE_NORMAL is set to 56dp actually and we should probably use that. Customizable option can be added in future.

I forgot to mention the likely cause for the border issue, it may have something to do with color.properties support that was setting the TerminalView background color but is fixed now, so not an issue.

dkramer95 commented 3 years ago

Android's FloatingActionButton.SIZE_NORMAL is set to 56dp actually and we should probably use that.

I have changed the default size to 56dp to follow this standard.

Customizable option can be added in future.

Ya, IMO I think bubble looks better slightly larger. But more incentive for me to work on this, as I'm sure other users will appreciate customizations :)

I forgot to mention the likely cause for the border issue, it may have something to do with color.properties support that was setting the TerminalView background color but is fixed now, so not an issue.

It worked out because I was able to get outline to draw a little nicer than before.

agnostic-apollo commented 3 years ago

I have changed the default size to 56dp to follow this standard.

Thanks. This perfectly matches flynx browser bubble as well.

think bubble looks better slightly larger. But more incentive for me to work on this,

Yeah, you right, you can fix your own problems here ;) Make sure to have min/max range

It worked out because I was able to get outline to draw a little nicer than before.

Yeah, I didn't even notice it before.