search

termux / termux-packages

A package build system for Termux.
https://termux.dev
Other
13.34k stars 3.07k forks source link

addpkg(x11-packages/musescore): MuseScore (and dependencies) #22304

Closed pipcet closed 4 days ago

pipcet commented 4 days ago

This PR contains three commits for three new packages, the main one of which is MuseScore. There is an Android app by the same name, but it appears to be predatory in nature, so adding the actual program to Termux might be a good idea.

Please let me know which parts of the build scripts need improving, I'd be happy to fix them. The current state is "it works".

I've added @termux as maintainer for all three packages.

The musescore package is about 64MB compressed, which is large.

The alsa-plugins package defaults to redirecting ALSA output to pulseaudio, which is probably what most people want these days.

pipcet commented 4 days ago

Thank you for the kind comments! I've tried to address them and pushed (no rebase, which would probably be a good idea to do pre-merge, particularly because there's a fixup).

The major change is the comparatively huge binary "soundfont" is now in its own subpackage.

TomJo2000 commented 4 days ago

Ah looks like the linter wasn't happy with the indentation on that.

I can fix it myself when I get up in the morning I wanted to see if this is ready for merge before I go to bed.

pipcet commented 4 days ago

Rebase and force-push to see whether that makes the CI pass. No changes to the eventual code.

TomJo2000 commented 4 days ago

Thank you for your contribution. :+1:

pipcet commented 3 days ago

Just reinstalled from the repo packages, MuseScore works after installing musescore and plays sound after installing musescore-soundfonts. Thanks!