Open pipcet opened 3 days ago
Could you please clarify whether this change might create any issues with the on-device package build?
Could you please clarify whether this change might create any issues with the on-device package build?
Good point. Maybe we should move this change to the section:
if [ "$TERMUX_ON_DEVICE_BUILD" = "false" ]; then
@TomJo2000 , does that make sense to you? I don't know anything about on-device termux builds...
Right I think that's what was nagging at the back of my mind. During on-device builds those are valid for CMake to pick.
If I could trouble either of you two for some symbol-fu really quick.
I'm having a hard time reasoning out why nvim
's Lua runtime isn't providing symbols to modules correctly like luajit
or lua5.1
do.
TL;DR Can we apply this patch to a test system and see whether it makes things better or worse?
Here's the issue:
sha256:25e51469574b174a940bc7970cba71d8f96ce228c8ddf7a60aedd61f32c87c68
)/bin/sh: 1: ccache: not found
The build process assumes there's a "ccache" binary in the path, even though the only copy of "ccache" is that in the /data directory. The problem is that CMake's
find_program
searches the install prefix unlessCMAKE_FIND_USE_INSTALL_PREFIX
is set, even thoughCMAKE_FIND_ROOT_PATH_MODE_PROGRAM=NEVER
is also set and affects the same directory.Problems:
find_program
is ever validly used to search for target executables rather than host executables. If that is the case, this change might break other packages.Obviously, it's perfectly possible for ccache to be a findable program but not reside on the PATH, but the code assumes it's always in the cache.
(It's generally a bad idea to automatically enable
ccache
without an explicit flag, but that's aswiftshader
problem, and we have to live with the broken CMakeLists.txt provided by the package maintainer)This popped up while working on #22305, but is unrelated.