search

termux / termux-packages

A package build system for Termux.
https://termux.dev
Other
13.34k stars 3.07k forks source link

Added rabbitmq-server package #22345

Closed brian7704 closed 1 day ago

brian7704 commented 1 day ago

Fulfills package request #10273 and seems to pass the criteria in the package request template

brian7704 commented 1 day ago

I think I made the requested changes correctly but let me know if anything else needs to be fixed. Thanks!

brian7704 commented 1 day ago

I made those changes and squashed the commits again

TomJo2000 commented 1 day ago

Thank you for your contribution :+1:

Oh one more procedural thing I noticed during merge. We somewhat follow conventional commits in the Termux repositories. https://github.com/termux/termux-packages/blob/master/CONTRIBUTING.md#commit-guidelines I've manually fixed the commit message during merge, but for future contributions please try to follow the commit message form: ```yml (/): ``` This is especially important when a PR is not being squashed down into a single commit because it does multiple things.

So the normalized commit message for this PR was: ```yml addpkg(main/rabbitmq-server): 4.0.3 (#22345) closes #10273 ``` The PR number is optional, but added automatically by GitHub when using the `Squash` merge type. `closes #10273` is special and signifies to GitHub that this commit resolves the given issue. See: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests
TomJo2000 commented 1 day ago

I added some additional information to the comment above in case it is helpful to anyone else coming across this PR in the future.