search

termux / termux-x11

Termux X11 add-on application.
https://termux.dev
GNU General Public License v3.0
1.85k stars 290 forks source link

Adapt to Samsung tab touchpad #543

Closed mistletoe235 closed 6 months ago

twaik commented 6 months ago

I did not say I will not merge this. I requested changes.

mistletoe235 commented 6 months ago

I'm sorry that I'm not fimiliar with Andorid development, the lib that include the constants not include the public static final int CLASSIFICATION_TWO_FINGER_SWIPE = 3; However, another project I saw has it. And the file is read only, So I don't know how to change it. image

twaik commented 6 months ago

I am talking about something else. You changed 0x4000000 to other value without providing a fallback to original value. And the same thing with other code.

Knightly-Spartan commented 6 months ago

@mistletoe235 can the 0x10000000 condition be added as just another else if block? so as to not change the existing 0x4000000 constant?

twaik commented 6 months ago

I'm sorry that I'm not fimiliar with Andorid development, the lib that include the constants not include the public static final int CLASSIFICATION_TWO_FINGER_SWIPE = 3

Probably not the best idea to inline constant, better to use the original name there.

can the 0x10000000 condition be added as just another else if block? so as to not change the existing 0x4000000 constant?

It can be used even in the same if block with logical OR.