search

termux / termux-x11

Termux X11 add-on application.
https://termux.dev
GNU General Public License v3.0
1.85k stars 290 forks source link

[Bug]: monochrome icon not work #585

Closed BinTianqi closed 4 months ago

BinTianqi commented 4 months ago

Problem description

ResizedImage_2024-03-19_21-51-57_1876

What steps will reproduce the bug?

  1. install this app on Android13 or above
  2. enable "Themed icons" in settings

What is the expected behavior?

the launcher icon should follow my system colors

BinTianqi commented 4 months ago

this app supports monochrome icon. ic_launcher.xml

<monochrome android:drawable="@mipmap/ic_launcher_monochrome"/>

android system will find ic_launcher_monochrome in mipmap folder. when api>=26, the system will try to find it in mipmap-anydpi-v26, but it doesn't exist, so the system decide to use normal icons.

twaik commented 4 months ago

Actually it does not exist in termux-app too, but it still works. @agnostic-apollo maybe you can tell me what is wrong to my app? 😭

BinTianqi commented 4 months ago

the app is missing ic_launcher_round.xml file like this

twaik commented 4 months ago

Ok, I see that ic_launcher_round.xml is the same as ic_launcher.xml so I'll try to make a copy of ic_launcher.xml in termux-x11 too.

BinTianqi commented 4 months ago

when I switch to square icon, it work fine

ResizedImage_2024-03-25_20-02-11_9708

twaik commented 4 months ago

https://github.com/termux/termux-x11/actions/runs/8419735350

twaik commented 4 months ago

Ok, you can test new build.

BinTianqi commented 4 months ago

Thank you for making my launcher more beautiful ResizedImage_2024-03-25_20-10-32_1800