termux / termux-x11

Termux X11 add-on application.
https://termux.dev
GNU General Public License v3.0
1.85k stars 290 forks source link

[feature request] option to factor in the height of extra keys bar into display dimension calculation #605

Closed knyipab closed 2 months ago

knyipab commented 3 months ago

The extra keys bar is currently shown on top of the display. The bar could indeed block what can be seen at the bottom of display, such as when browsing websites in a maximized browser window. It could cause inconvenience for users who want to have the bar always on, or he/she would need to hide the bar every time to see the bottom of display and then toggle the bar again.

Therefore, it would be really great to have an option to make the app to recalculate display dimension so not to overlap with the extra keys bar whenever the bar is toggled. Thank you.

twaik commented 3 months ago

The extra key bar was designed to be toggled on or off as needed. Intentionally. For convenient switching, you can use two gestures: a three-finger swipe or the "volume down" button (activated in the settings).

Recalculating size of EK bar and screen surface was used in older versions but it was removed because it caused flickering of screen and there is no fix for this. It will not be back again.

knyipab commented 3 months ago

Similar to #607. Do you mind me putting this feature in a sub-page called "unstable features"?

Still, this option can be useful. Even with three-finger gesture, using the arrow buttons to navigate the terminal at the bottom of VS Code is a pain. I am happy to make a pull request to make available an option under "unstable features".

knyipab commented 3 months ago

Inspired by RealVNC viewer, an option for opacity of EK bar through .setAlpha() can be a good alternative to PR #618 , at least solving the pain point of using vs code terminal. I could implement, subject to your view.

twaik commented 3 months ago

Probably it is a nice idea.

twaik commented 2 months ago

Closed by #618