search

termux / termux-x11

Termux X11 add-on application.
https://termux.dev
GNU General Public License v3.0
2k stars 303 forks source link

[Bug]: hardware keyboard workaround not working #648

Closed knyipab closed 3 months ago

knyipab commented 4 months ago

Problem description

Continuation of #635 because it is actually not fixed. I opened this issue to prevent forgetting about it.

What steps will reproduce the bug?

https://github.com/termux/termux-x11/commit/3c8cc7591dc7d0a8c6f21afed915c42e1a980b48 does not work without setting outAttrs.inputType.

My previous test results are based on this PR #620 (cuz you mentioned BaseInputConnection at the beginning).

If you don't want to merge PR #620 any time soon, may consider to add this to LorieView. Note that Termux:App does the same thing in this line.

    @Override
    public InputConnection onCreateInputConnection(EditorInfo outAttrs) {
        outAttrs.inputType = InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_FLAG_NO_SUGGESTIONS | InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD;
        return super.onCreateInputConnection(outAttrs);
    }

What is the expected behavior?

No response