search

termux / termux-x11

Termux X11 add-on application.
https://termux.dev
GNU General Public License v3.0
2k stars 303 forks source link

Fix touchpad transform having no effect #650

Closed TudbuT closed 3 months ago

TudbuT commented 4 months ago

The Touchpad transform currently has no effect because the TouchInputHandler mTouchpadHandler does not receive updates to the config. I looked through the uses of it and found out that although one could apply a far simpler patch, the mTouchpadHandler actually has no extra functionality and can be removed without any change in behavior. This both reduces code complexity and fixes the touchpad transform.

If this solution is unwanted, I can move to the smaller patch instead - though I personally don't see any metric where that solution would be better unless mTouchpadHandler has some very obscure function that I wasn't able to find or discover during preliminary testing.

twaik commented 4 months ago

https://github.com/termux/termux-x11/pull/617#issuecomment-2138735489

TudbuT commented 4 months ago

Alright, that makes sense I suppose. Hold on.

TudbuT commented 4 months ago

That should fix it now.