OpenXR - BT/OTG support and hardcode native resolution

termux / termux-x11

Termux X11 add-on application.

https://termux.dev

GNU General Public License v3.0

1.94k stars 301 forks source link

OpenXR - BT/OTG support and hardcode native resolution #671

Closed lvonasek closed 1 month ago

lvonasek commented 2 months ago

This addresses XR issues mentioned in https://github.com/termux/termux-x11/issues/665.

Support XR mode without controllers (patch of AndroidManifest.xml)
Set resolution for "native" lower (patch of LorieView.java)
Support for BT/OTG keyboard (patch of XrActivity.java)

twaik commented 2 months ago

There are pending reviews.

twaik commented 1 month ago

@lvonasek can you please read pending reviews and respond?

lvonasek commented 1 month ago

I responded to not answered reviews (although I thought this was clear, I am sorry for the misunderstanding).

About the answer from @natebragg:

twaik that did not work, although I was only able to test it in XR mode, since the option to disable it was not present in the preferences

I think the user reacted to ctrl+space issue which isn't expected to work in the XR mode neither (the same issue like #665).

twaik commented 1 month ago

They are still considered to be pending. Screenshot_20240714_094501_Brave

lvonasek commented 1 month ago

They are still considered to be pending. Screenshot_20240714_094501_Brave

There must be some issue with GitHub. These comments aren't visible for me. But let me clarify it here: dispatchKeyEventPreIme is called, with randomly receiving KEYCODE_MEDIA_PLAY from software keyboard. But only up events.

These events are not passing into dispatchKeyEvents. Do you still require to add KEYCODE_MEDIA_PLAY filtering although there is no negative effect by it?

I personally prefer to avoid "hacky" code if it is not necessary.

twaik commented 1 month ago

What about the last one?

lvonasek commented 1 month ago

What about the last one?

Yes, dispatchKeyEventPreIme is called correctly.