termux / x11-packages

A set of packages using X11 Windows System.
Other
547 stars 145 forks source link

bspwm: Fix another hardcoded paths #668

Closed Yonle closed 2 years ago

Yonle commented 2 years ago

Originally done by @NoNameMan1231 at https://github.com/termux/x11-packages/pull/666 Added another patch as i found another hardcoded paths.

Dawimpy commented 2 years ago

@Yonle Thanks for helping me!

Yonle commented 2 years ago

As i found some of a messy patch, I'm not done yet. So do not pull me until i undraft this pull

Dawimpy commented 2 years ago

Looks like we needed to digging over the source code...

Yonle commented 2 years ago

Looks like we needed to digging over the source code...

Well, some fact is that i've digged all the source codes with grep -R "/tmp".

Dawimpy commented 2 years ago

@Yonle you must add ./ in first two line of patch

Just like ./foo/bar instead of foo/bar

Dawimpy commented 2 years ago

@Yonle does all those annoying hardcoded bug is fixed? Just want to make sure...

Yonle commented 2 years ago

@Yonle does all those annoying hardcoded bug is fixed? Just want to make sure...

Yes it's.

Dawimpy commented 2 years ago

Do you use your own script on GitHub? I just starred it...

Yonle commented 2 years ago

Do you use your own script on GitHub? I just starred it...

In theory, i did the same as how my project does, but with my own hand.

In fact, It does the same thing.