Closed tomsaleeba closed 2 years ago
I just realised the code that throws the error is in our code base (not a dependency).
Looking at those properties, they look like minified property names. Possible theory: this worked on the initial commit because the minified property names matched, but those names can change on every rebuild, so they no longer work. The trick will be to avoid having to use these minified names. Maybe we can swap to using a non-minified version of the maps code (not exactly sure where that is) so the field names are predictable.
@j-robinson could you please try to reproduce this bug and fix it if you have time.
CC @tokmakoff
Setting a break point on that code, it seems like the property names in my build are Ab
and Va
.
Thanks for figuring out what the issue was @tomsaleeba. Luckily there are methods for accessing those properties so it was an easy fix https://github.com/ternandsparrow/wild-orchid-watch-pwa/commit/c04ab8bf878c87e8bb33f817d035ffbe09892abe
Works great, thanks :muscle:
Env Firefox 100, Chromium 101 both on Linux
Steps
Expected The pin updates to the center of the map and no errors are shown in the console
Actual The pin on the map does not update and many errors (all the same) appear in the console. The error messages (in Firefox) are
That first line of the trace points to![image](https://user-images.githubusercontent.com/1773838/168950494-8ffacec3-442e-421b-8452-f5333f33865c.png)
Here's a screencast of the bug
https://user-images.githubusercontent.com/1773838/168950531-02855e66-0579-4cbf-99f2-fc3663653a2a.mp4
I swear this worked great when it was first added and I haven't bumped dependency versions (pretty sure I haven't) so I don't know what's gone wrong. Maybe the underlying JS that drives Google Maps has changed because it's pulled live and not part of our dependencies :thinking: .