ternaris / marv

THIS REPOSITORY HAS BEEN MERGE INTO
https://github.com/ternaris/marv-robotics
GNU Affero General Public License v3.0
3 stars 4 forks source link

Documentation of the new Trajectory Widget #21

Closed beetleskin closed 6 years ago

beetleskin commented 6 years ago

With the old Leaflet-Widget, it was relatively straight forward what features were supported. Since you now use your own proprietary renderer, a documentation is needed:

The most important thing to tune, for me right now, is the stroke width of the lines since the trajectory is hardly visible on the map. You got "weight" and "markersize" as properties, but they don't seem to have any influence on the rendering.

Also, within the source code, your variables suggest that you use "GeoJSON" but the objects and their structure looks slightly different from the official specs. Some clarifications would be nice here.

Ref: #9

NikolausDemmel commented 6 years ago

I agree that documentation is needed.

We have been using the following features:

If you need help with those in particular, I might be able to dig in our latest configuration.

beetleskin commented 6 years ago

The playback sounds interesting, how did you manage this?

I found the capnp types of GeoJson, they give a hint on what might be supported by the trajectory renderer in the frontend. I didn't try all the properties yet though.

UPDATE Unfortunately the properties dont't have much effect, i.e. are not supported by the renderer.

chaoflow commented 6 years ago

@beetleskin The player functionality is EE-only, documentation is planned for the upcoming release. In short:

chaoflow commented 6 years ago

@beetleskin I just verified that adding a 'weight': 10 to https://github.com/ternaris/marv-robotics/blob/34c18d90ce150a96a3d82219f47c7f0630634039/marv_robotics/trajectory.py#L87 leads to a line with more weight.

Note, that you need to also force run trajectory_section for the newly rendered trajectory to be used. The upcoming release will introduce marv run --force-dependent to achieve this.

beetleskin commented 6 years ago

Thanks. But weight does not work for me in combination with LineString. The line is only 1px, no matter to what value weight is set to:

feat = {
            'properties': {
                'color': color,
                'weight': 5.0
            },
            'geometry': {
                'line_string': {
                    'coordinates': feature_coordinates
                }
            }
        }
beetleskin commented 6 years ago

Got it .. it works in Chromium, but not in FF (57.0.4 (64-bit), Ubuntu 16.04)