ternaus / retinaface

The remake of the https://github.com/biubug6/Pytorch_Retinaface
MIT License
393 stars 107 forks source link

google-colab 1.0.0 has requirement ipykernel~=4.10 #28

Open woctezuma opened 3 years ago

woctezuma commented 3 years ago

Thank you for the PYPI module.

For information, people using Google Colab have to restart their runtime after they pip install the module.

ERROR: google-colab 1.0.0 has requirement ipykernel~=4.10, but you'll have ipykernel 5.3.4 which is incompatible.
WARNING: Upgrading ipython, ipykernel, tornado, prompt-toolkit or pyzmq can
cause your runtime to repeatedly crash or behave in unexpected ways and is not
recommended. If your runtime won't connect or execute code, you can reset it
with "Factory reset runtime" from the "Runtime" menu.
WARNING: The following packages were previously imported in this runtime:
  [ipykernel]
You must restart the runtime in order to use newly installed versions.

This happens because of the requirements of streamlit.

pydeck>=0.1.dev5->streamlit->retinaface_pytorch) (4.3.3)
Collecting ipykernel>=5.1.2; python_version >= "3.4"
  Downloading https://files.pythonhosted.org/packages/52/19/[...]/ipykernel-5.3.4-py3-none-any.whl (120kB)
     |████████████████████████████████| 122kB 54.6MB/s 

If I run pip install streamlit, I can see the following, which confirms my suspicion:

Requirement already satisfied: ipykernel>=5.1.2; python_version >= "3.4"
in /usr/local/lib/python3.6/dist-packages (from pydeck>=0.1.dev5->streamlit) (5.3.4)

I wonder if it would be possible to downgrade the version of ipykernel or remove the streamlit requirement altogether.

woctezuma commented 3 years ago

Alright, I guess this is due to:

https://github.com/ternaus/retinaface/pull/18/commits

You might need to upload another build to PYPI without the streamlit requirement, after this commit from November:

commit

https://github.com/ternaus/retinaface/commit/62647d379e0d7a936615f64fbf10e92114ced8f0#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552

which I found thanks to the history of requirements.txt:

https://github.com/ternaus/retinaface/commits/master/requirements.txt

As you can see the build on PYPI is from August:

PYPI build