ternaustralia / dawe-rlp-vocabs

Controlled vocabularies for the EMSA field survey protocols.
https://linkeddata.tern.org.au/viewers/dawe-vocabs
2 stars 2 forks source link

Update_herbvi_phys_vocabs_v2 #560

Closed arunherb closed 3 weeks ago

arunherb commented 1 month ago

Updated Vocabs aligned to version-2 of the Herbivory and Physical Damage Module

arunherb commented 1 month ago

@junrongYu - I have updated the categorical concept 'age class' to 'fauna growth class' and also the collection label to 'fauna growth classes' as discussed during the meeting on EMSA version-2 updates.

junrongYu commented 1 month ago

Hi @arunherb , thanks for the update. Looks like the concept URI of new OPs damage area and additional damage type are the same, can you please generate a new UUID for additional damage type and add it to the relevant OPs' collection file? also in the metadata file. Also, I see you renamed the metadata file of OP physical damage type to additional damage type, does that mean these 2 observations cannot both exist in this module? Thanks!

arunherb commented 1 month ago

Hi @arunherb , thanks for the update. Looks like the concept URI of new OPs damage area and additional damage type are the same, can you please generate a new UUID for additional damage type and add it to the relevant OPs' collection file? also in the metadata file. Also, I see you renamed the metadata file of OP physical damage type to additional damage type, does that mean these 2 observations cannot both exist in this module? Thanks!

Hi @junrongYu - The first one is Done. For thesecond one, I have added the 'physical damage type' in the metadata file. They are two different observations.

junrongYu commented 1 month ago

Hi @arunherb , thanks for the update. Looks like the concept URI of new OPs damage area and additional damage type are the same, can you please generate a new UUID for additional damage type and add it to the relevant OPs' collection file? also in the metadata file. Also, I see you renamed the metadata file of OP physical damage type to additional damage type, does that mean these 2 observations cannot both exist in this module? Thanks!

Hi @junrongYu - The first one is Done. For thesecond one, I have added the 'physical damage type' in the metadata file. They are two different observations.

Hi @arunherb , looks like the URI of OP damage area is replaced by additional damage type, can you please bring it back into the relevant collection file? I mean adding OP URI https://linked.data.gov.au/def/nrm/a1f5f46b-d6fe-4a1f-8fa8-01b113a2d69f back. Also, for physical damage type metadata files, should the value type be tern:IRI? Also, the value of urnp:observablePropertiesCollection seems to be the categorical collection URI, can you please change the predicate and add the OP collection URI here? Thanks!

arunherb commented 1 month ago

Hi @arunherb , looks like the URI of OP damage area is replaced by additional damage type, can you please bring it back into the relevant collection file? I mean adding OP URI https://linked.data.gov.au/def/nrm/a1f5f46b-d6fe-4a1f-8fa8-01b113a2d69f back. Also, for physical damage type metadata files, should the value type be tern:IRI? Also, the value of urnp:observablePropertiesCollection seems to be the categorical collection URI, can you please change the predicate and add the OP collection URI here? Thanks!

Done

junrongYu commented 1 month ago

Hi @arunherb , looks like the URI of OP damage area is replaced by additional damage type, can you please bring it back into the relevant collection file? I mean adding OP URI https://linked.data.gov.au/def/nrm/a1f5f46b-d6fe-4a1f-8fa8-01b113a2d69f back. Also, for physical damage type metadata files, should the value type be tern:IRI? Also, the value of urnp:observablePropertiesCollection seems to be the categorical collection URI, can you please change the predicate and add the OP collection URI here? Thanks!

Done

Hi @arunherb , you added the same OP collection URI for three sub protocols, also, can you please add the categorical collection URI as well, it is to add this line into each metadata file of OP physical damage type: urnp:categoricalValuesCollection <https://linked.data.gov.au/def/nrm/51fa78ee-187a-5788-9fe0-e68cc476ea91> ;


Also, looks like the metadata URI of OP damage area was added in the collection file, not the concept URI, can you revert it? it is in the file vocab_files/observable_properties_by_module/herbivory-and-physical-damage/active-search-protocol/collection.ttl, replace metadata URI https://linked.data.gov.au/def/nrm/b2148c3a-e21c-4393-beb9-f0d98fd8594f with concept URI https://linked.data.gov.au/def/nrm/a1f5f46b-d6fe-4a1f-8fa8-01b113a2d69f Thanks!

junrongYu commented 3 weeks ago

Hi @arunherb , thanks for the updates, can you please have a look at following:

  1. for the new LUT herbivory or physical damage types, can you please add its URI in file collection-members.ttl, which is the top level LUT collection.
  2. for NVIS relevant concepts in categorical_concepts.ttl, some of them have notation in prefLabel, can you please separate them? it's to move MVS / MVG + NUM in prefLabel to skos:notation
  3. can you please add the concept URI of attribute target observation direction to fauna ground counts - vantage point, it was ignored in fauna ground counts
  4. Also, we forgot to link the relationship between attributes and ontology classes, I've listed them in the confluence page, can you please add them? Thanks!
arunherb commented 3 weeks ago

Hi @arunherb , thanks for the updates, can you please have a look at following:

  1. for the new LUT herbivory or physical damage types, can you please add its URI in file collection-members.ttl, which is the top level LUT collection.
  2. for NVIS relevant concepts in categorical_concepts.ttl, some of them have notation in prefLabel, can you please separate them? it's to move MVS / MVG + NUM in prefLabel to skos:notation
  3. can you please add the concept URI of attribute target observation direction to fauna ground counts - vantage point, it was ignored in fauna ground counts
  4. Also, we forgot to link the relationship between attributes and ontology classes, I've listed them in the confluence page, can you please add them? Thanks!

Done