ternaustralia / dawe-rlp-vocabs

Controlled vocabularies for the EMSA field survey protocols.
https://linkeddata.tern.org.au/viewers/dawe-vocabs
2 stars 2 forks source link

Signs_v2 - updates #562

Closed arunherb closed 2 weeks ago

arunherb commented 1 month ago

Updated 'scat removal status' labels, in 'categorical concept file' and d metadata file; and renamed 'number of transects to be completetd'

junrongYu commented 4 weeks ago

Hi @arunherb , thanks for the updates, I have some questions:

junrongYu commented 2 weeks ago

Hi @arunherb , thanks for the updates, can you please have a look at following issues:

  1. In this commit, https://github.com/ternaustralia/dawe-rlp-vocabs/pull/562/commits/7a00c23af472766a9032cfc5ae687df31bfbedee, need to add attribute transect id, but attribute transect ID code was added;
  2. For OPs fauna sign comments and fauna sign presence, can you please remove the tern:valueType in concept files, cuz it's defined in metadata files;
  3. In within plot and off plot, the metadata files of OP fauna sign presence should have quadrat as its feature type, the URI is http://linked.data.gov.au/def/tern-cv/4362c8f2-b3cc-4816-b5a2-fb7bb4c0cff5
  4. In the new LUT track station substrates, for each metadata, values of urnp:categoricalCollection and schema:url are not correct; And looks like the metadata of concepts sand and tracking pad are mixed, probably because they used the same metadata URI, can you please fix it?
  5. Can you please remove the tern:isAttributeOf in the concept file of OP fauna sign comments cuz it was converted to OP, not attribute now;
  6. In the concept file for attribute fauna track photo ID, tern:Sample and tern:FeatureOfInterest are both values of tern:isAttributeOf, can you please fix it? Thanks!
arunherb commented 2 weeks ago

Hi @arunherb , thanks for the updates, can you please have a look at following issues:

  1. In this commit, 7a00c23, need to add attribute transect id, but attribute transect ID code was added; - DONE
  2. For OPs fauna sign comments and fauna sign presence, can you please remove the tern:valueType in concept files, cuz it's defined in metadata files; Done
  3. In within plot and off plot, the metadata files of OP fauna sign presence should have quadrat as its feature type, the URI is http://linked.data.gov.au/def/tern-cv/4362c8f2-b3cc-4816-b5a2-fb7bb4c0cff5 Done
  4. In the new LUT track station substrates, for each metadata, values of urnp:categoricalCollection and schema:url are not correct; And looks like the metadata of concepts sand and tracking pad are mixed, probably because they used the same metadata URI, can you please fix it?Done
  5. Can you please remove the tern:isAttributeOf in the concept file of OP fauna sign comments cuz it was converted to OP, not attribute now; Done
  6. In the concept file for attribute fauna track photo ID, tern:Sample and tern:FeatureOfInterest are both values of tern:isAttributeOf, can you please fix it? Done Thanks!
junrongYu commented 2 weeks ago

Hi @arunherb , thanks for the updates, looks like the file path in schema:url for metadata is still wrong, can you please fix it? for LUT track substrate types

arunherb commented 2 weeks ago

Hi @arunherb , thanks for the updates, looks like the file path in schema:url for metadata is still wrong, can you please fix it? for LUT track substrate types

Thanks for checking this. I have fixed it now.