search

ternjs / tern_for_sublime

Sublime Text package adding Tern support
MIT License
803 stars 54 forks source link

Fix installation on windows #142

Closed colthreepv closed 7 years ago

colthreepv commented 7 years ago

I noticed different issues regarding ternjs install on windows, I had problems myself, the default answer in the issues is "manually do npm install"

This is not a terrible workaround, but still, is a workaround

Using shell=True on windows let the installer run smoothly (it's a PATH problem, without shell), I also added loglevel=silent on npm to avoid it returning code 1 because it couldn't write on STDERR/STDOUT

I am no python programmer, so don't expect a classy PR... it's just a bugfix one

marijnh commented 7 years ago

That does look good. Thanks. Merged as fc990ea