search

ternjs / tern_for_sublime

Sublime Text package adding Tern support
MIT License
803 stars 54 forks source link

Feature/describe #98

Closed tansongyang closed 8 years ago

tansongyang commented 8 years ago

Added describe functionality. Used alt+o to make it similar to the existing shortcuts and the online demo.

Most major changes took place in renderer.py. This involved extracting a common base class, RendererBase, where before there were 3 separate classes.

The only thing I don't like is that some things are still named with "arghints", particularly Tern.sublime-settings. However, this is now a bit of a misnomer since you can display other things besides argument hints. I was hesitant to change this since it's a user-facing setting. What are your thoughts on this?

marijnh commented 8 years ago

Merged, in squashed form, as 5daa3375dbcb...068a5ef02343. Followed up with 3d1daecea381ff, which binds the output style option to a saner option name (without dropping the old name), and fixes a bug where the new feature would fail if you had arghints disabled.