teroparvinen / foundry-wire

10 stars 4 forks source link

Wire attack roll dialog does not support Advantage Reminder messages #11

Open JulieWinchester opened 1 year ago

JulieWinchester commented 1 year ago

I'm not sure if you consider this in scope for this module, but the custom attack roll dialog does not support Advantage Reminder messages like the normal roll dialog does. The messages don't seem to appear at all.

teroparvinen commented 1 year ago

I've seen this pop up in a couple of places and wouldn't mind some feedback from actual users of that module. I'm open to integrations with other modules provided I can find the time, but I need to understand why.

The concept of WIRE is to have most everything like this automatically added to the roll, i.e. the very idea of the module is to not have to remember these things or be reminded of them.

There are some problematic cases where a really spot on technical solution is hard to even imagine like Guidance where I can see people choosing the option that best suits them personally, but most Advantage Reminder things I've seen have been pretty mundane and quite easily handled just by setting them up for WIRE and having them work automatically.

Can you give me some situations where this would be complementary to what WIRE does, assuming everything is set up right?

JulieWinchester commented 1 year ago

Thanks for this response. I think it would be completely understandable to consider something like Advantage Reminder out of scope for WIRE.

I'm not the heaviest AR user, so maybe others could comment on this better. The ways where I could potentially see AR as complementary to WIRE would be in cases where the application of a bonus from an effect would be conditional? Guidance is of course an example of this, like you mentioned. But also something like Sneak Attack bonus damage could be as well. I'm sure that could be set up as an effect that grants bonus damage and then disappears (like Smite), but for my less technically inclined players, they would likely benefit from an always-on Sneak Attack reminder effect that uses AR to remind them that they can apply sneak attack damage to a roll. In my experience, I usually find myself trying to meet my players at their level of comfort and familiarity with Foundry and its complexities, and sometimes for "soft" conditionals, that easiest way for me is through low-automation things like reminders? But again, maybe that's not in WIRE's scope.

Going completely off-topic (but still relating to conditionally-applied effects controlled by players), I love the WIRE custom attack roll dialog, it reminds me of the Foundry PF2E attack roll dialog in how it clearly splits out roll bonuses and describes the source of bonuses (ability bonus, proficiency bonus, etc.). The one extra bit of functionality that the PF2E attack roll dialog has is that it lists per-effect bonuses, and allows players to toggle those bonuses on and off in the roll dialog. That's how PF2E handles Guidance - the player has an effect that grants a bonus that is disabled by default, but can be toggled from off to on for a single roll. If the focus of WIRE is on not making decisions automatically, but rather presenting players with as much about rolls and workflows as possible in a convenient way, maybe something like that would be in scope? I've played around with implementing something like this on top of the base dnd5e system before, and it seems like WIRE is part of the way there already.

teroparvinen commented 1 year ago

I'm going to grab Advantage Reminder and have a look. I think the Sneak Attack example was at least reasonable.

The one extra bit of functionality that the PF2E attack roll dialog has is that it lists per-effect bonuses, and allows players to toggle those bonuses on and off in the roll dialog

I would have loved to do it this way, but the dnd5e system builds the attack bonuses from the fields that are displayed on the custom dialog. All bonuses from effects are clumped into one and you can no longer tell where they originate. I guess I could override this as well from the system and do the calculations, but I've tried to use existing functionality where possible. Even though this will not go in while there is other more urgent stuff on the todo list, I will keep it in mind.

kaelad02 commented 1 year ago

AR author here. I'd be interested to see where AR can augment what WIRE is trying to do. One of the recent features I added was to explain where advantage came from (i.e. list the name of the active effect that gave advantage). While that stuff could be integrated into WIRE, we could also find a way for WIRE to use what AR already does (some custom hooks come to mind).

As for the message examples, you've already mentioned Sneak Attack and Guidance. There are a couple of racial features (e.g. Dwarven Resilience and Fey Ancestry) where AR messages are useful since they give advantage on things that aren't always tagged properly. There are others that I've seen where some prefer to handle a Paladin's smite this way, with buttons for the extra damage then they'll consume a spell slot later. Might be a better workflow for that one, but it's another use case I've seen. Even heard of someone adding a message when the PC has inspiration, to remind them about it in case they want to use it. Again, WIRE could do something specifically with that in another way.

Sneak Attack reminds me of other bonus condition triggers AR can help with:

kaelad02 commented 1 year ago

And an idea for the off-topic part, labeling bonuses... You could try deconstructing bonuses like the system does for AC. I'd have to double-check the code for the exact details, but I know part of it looks at the active effects on the actor to figure out how the bonus part was made so it can show it in the character sheet.

YenBenGrey commented 1 year ago

Hello, just wanted to add to this as I like AR and WIRE, therefore if they could work together that would be great.

Here is what I have done today briefly with screenshots.

I don't have Midi-Qol installed however look at this....but I do have WIRE installed and live.

If the screenshots are in the right order then it should be Midi-Qol in first and then WIRE. (all these are with WIRE live)

So it isn't a million miles away, says me who has no idea how to work or program these things.

Screenshot 2023-02-04 at 19 17 23 Screenshot 2023-02-04 at 19 23 28 Screenshot 2023-02-04 at 19 18 00 Screenshot 2023-02-04 at 19 18 42