search

teroparvinen / foundry-wire

10 stars 4 forks source link

Issue: Duplicate effects on token placement when wire + libwrapper + socketlib are active at the same time. #33

Closed DreamingHero1997 closed 1 year ago

DreamingHero1997 commented 1 year ago

It seems all effects on a character are duplicated on a token when it is placed, however if libwrapper or socketlib are disabled then this doesn't occur, same if those two are active but wire isn't. It's quite a disruptive issue,

teroparvinen commented 1 year ago

Could you post the steps to replicate this so I could make sure I have the issue pinpointed.

I can replicate this when multiple copies of a linked token (like multiple tokens for a PC) are created, and only for transfer effects. This definitely deserves looking into, but is typically not very disruptive so that is why I'm thinking I've missed something.

The socketlib aspect is almost certainly related to the fact that WIRE delegates many responsibilities to the GM client to apply effects on actors the players don't have permission on, and that is cut.

DreamingHero1997 commented 1 year ago

Okay so I've tested it more and it seems to only happen with items when the item's source within the effects is not properly set, this is mostly a problem with items that were created in earlier versions of foundry, now whenever an effect is made the source properly ties to the item.

Its actually quite easy to fix by just drag & dropping the effect onto the item again, it gets duplicated thanks to a module im using and this issue does not occur anymore for these items.

YenBenGrey commented 1 year ago

How do you drag and drop an effect on to an item? What module was duplicating? just so I can check my set up. Cheers.

DreamingHero1997 commented 1 year ago

This can be done thanks to the library active effect manager and enabling the drop on items option, do note I disabled all modules except the three mentioned when testing for the bug, at which point I drag & dropped between items to copy an effect and also created a new one to test the issue. The sources in both cases were corrected and thus the issue did not occur. image

YenBenGrey commented 1 year ago

Thank you.

teroparvinen commented 1 year ago

@DreamingHero1997 I'm going to close this as it seems this isn't directly caused by WIRE. I will keep the root cause in mind if any future issues pop up.