search

teroparvinen / foundry-wire

10 stars 4 forks source link

[Bug] Magical Weapons not ignoring resistance #45

Closed Geekswordsman closed 1 year ago

Geekswordsman commented 1 year ago

D&D 5e v2.1.5 WIRE v0.10.12

Barebone world, only WIRE enabled. A creature with immunities to Bludgeoning, Piercing, and Slashing from attacks that are not magical still has resistances applied when hit with a weapon that has the magical property.

See attached.

image image image

DreamingHero1997 commented 1 year ago

To add to this, it seems this needs to be fixed for all physical weapon properties and the physical weapon properties bypassing should also work the WIRE's flags.wire.damagereduction.bludgeoning/physical/piercing/slashing types.

teroparvinen commented 1 year ago

[...] the physical weapon properties bypassing should also work the WIRE's flags.wire.damagereduction.bludgeoning/physical/piercing/slashing types.

This part is problematic because the bypass flags are specific to damage immunity, damage resistance and damage vulnerability. They might differ and there is no way to map them to the damage reduction options available through the flag. I will probably keep this so that if a weapon has the "Magical" property, it will bypass physical damage reduction.