search

terra-farm / terraform-provider-virtualbox

VirtualBox provider for Terraform
https://terra-farm.github.io/provider-virtualbox/
MIT License
323 stars 136 forks source link

feat: allow setting vm firmware #129

Closed ghouscht closed 1 year ago

ghouscht commented 2 years ago

Hi, As stated in https://github.com/terra-farm/go-virtualbox/pull/28 I need this to create VMs which only support EFI boot, which is now working with these changes. Thank you, Thomas

ghouscht commented 2 years ago

The changes you added look good, but what is missing is adding the ability to read the firmware back in resourceVMRead function.

if err = d.Set("firmware", vm.Firmware); err != nil {
  return diag.Errorf("can't set firmware: %v", err)
}

Uh, good catch, I missed that, sorry. Also done with the latest changes.

ghouscht commented 2 years ago

HI @VoyTechnology, Any chance to get this merged in the near future? Thanks, Thomas