terra-farm / terraform-provider-virtualbox

VirtualBox provider for Terraform
https://terra-farm.github.io/provider-virtualbox/
MIT License
323 stars 134 forks source link

Add dependency version management using dep #30

Closed VoyTechnology closed 6 years ago

VoyTechnology commented 6 years ago

The change would allow to have better control over the dependencies and their changing versions.

VoyTechnology commented 6 years ago

I am aware the CI has failed and I'm looking into it.

VoyTechnology commented 6 years ago

My last commit fixed the issue. However dep ensure took 281.90s, which is less than ideal. Should I add caching in this PR? dep ensure will make sure the dependencies are of correct version, so there is no need to worry about old packages being used.

ringods commented 6 years ago

@VoyTechnology I merged this PR for now. If you still want to add caching, feel free to create a new PR. Thanks already for providing the dep support.