Add go modules dependency management.

terra-farm / terraform-provider-virtualbox

VirtualBox provider for Terraform

https://terra-farm.github.io/provider-virtualbox/

MIT License

324 stars 136 forks source link

Add go modules dependency management. #36

Closed VoyTechnology closed 5 years ago

VoyTechnology commented 5 years ago

Go 1.11 added Go modules support. This is a direct addition of the necessary modules files using go mod init, which used the go dep lock file to determine the dependencies.

Déjà vu? https://github.com/terra-farm/terraform-provider-virtualbox/pull/30

Ideally the Gopkg.toml and Gopkg.lock would be removed, but I know that go modules have not reached full support of the community yet, so I kept them for now, but let me know if they should be removed.

ringods commented 5 years ago

@VoyTechnology I would very much like to switch to go modules completely. I'm not sure what tooling everyone uses to do Go development, but for VSCode (which I'm using), go modules are not yet fully supported:

https://github.com/Microsoft/vscode-go/wiki/Go-modules-support-in-Visual-Studio-Code

Are you OK with postponing a full switch to go modules?

VoyTechnology commented 5 years ago

So far I had no problems using modules with VSCode, but I am working outside of GOPATH for all my projects now, so maybe that's why I haven't encountered any problems.

I can postpone, this is not blocking me in any way. Perhaps we can keep all conversations about when to switch to modules in #38, so people can just watch that issue (if they are interested).