Replace dep with Go Modules

terra-farm / terraform-provider-virtualbox

VirtualBox provider for Terraform

https://terra-farm.github.io/provider-virtualbox/

MIT License

324 stars 136 forks source link

Replace dep with Go Modules #38

Closed VoyTechnology closed 5 years ago

VoyTechnology commented 5 years ago

Originally I have created #30, which was the most up to date dependency management software at the time. But since then Go Modules came out. Go 1.11 added preliminary support for it, so I think we should look at potentially replacing dep with it.

Below are the steps which are necessary to make go modules work and deprecate go dep.

[x] Add go.mod files to the repo - #36
[x] Use Go 1.11.4 in Travis - #37
[x] Switch to use go modules in .travis.yml - #43
[x] Remove Gopkg.toml and Gopkg.lock - 8af001e

ringods commented 5 years ago

Contributions to Go 1.11 welcome! I want the providers to be in shape by the time TF 0.12 is released. Looking in the TF 0.12 dev branch, Go 1.11 is dependency there.

VoyTechnology commented 5 years ago

Technically we can switch to Go modules in Travis anyways, as it is not depending on any development workflow.

This transition period is a bit awkward, but I will soon update all dependencies, and will make sure that both dep and mod are covered.

VoyTechnology commented 5 years ago

Updated the issue body, as #43 does stage 3 of the migration.

ringods commented 5 years ago

@VoyTechnology I dropped the dep setup in commit 8af001e. We are now fully on go modules for the virtualbox provider and wrapper library.