search

terra-farm / terraform-provider-virtualbox

VirtualBox provider for Terraform
https://terra-farm.github.io/provider-virtualbox/
MIT License
324 stars 136 forks source link

Fix go linting problems. #44

Closed VoyTechnology closed 5 years ago

VoyTechnology commented 5 years ago

Fix the problems with Go styling, such as serious underscores_in_variables, as well as less pressing issues, but still following the Go's Code Review Comments wiki page.

Side effect is that errors are actually tracable and a full error log message is visible.

I am sorry if this feels like an offence to the original authors of the code - I realize that people don't always have time to write perfect code. If this repo is to be approved into the official list, we need to improve the code health (#5)

And another apology to the reviewer for such a long change, but I don't think splitting it up and depending on other PRs would be worth it.

VoyTechnology commented 5 years ago

@ringods I have rebased the changes, PTAL

VoyTechnology commented 5 years ago

I will squash the commits post-review