search

terra-farm / terraform-provider-virtualbox

VirtualBox provider for Terraform
https://terra-farm.github.io/provider-virtualbox/
MIT License
324 stars 136 forks source link

Prepare for v1.0 #50

Open VoyTechnology opened 5 years ago

VoyTechnology commented 5 years ago

The purpose of this issue is to collect feedback and track requirements for v1.0.0 release, designed for Terraform v0.12. This issue would be updated based on the feedback, and when consensus is reached as to what should be in v1.0.0, the issue would be locked, updated when a particular point is done and closed when the release is available. Additionally, a milestone would be created to track progress.

VoyTechnology commented 5 years ago

Here are a couple of my suggestions:

  1. Establish the owners and official maintainers of the repository, and document it in README for transparency.
  2. Improve log transparency. #44 adds logs propagation which should make it easier to see the cause of an issue directly when running terraform plan|apply.
  3. Add image checksum validation
  4. Allow different methods of fetching the images. After #40 the supported types would be HTTP/HTTPS and locally. We should at the very least also add the most common cloud ones like AWS and GCP.
  5. Completely deprecate dep and just use go modules. (#38)
  6. Add tests

This is all I can think for now, but please let me know what do you think. Because of point 1 I don't even know who to tag :)

ringods commented 5 years ago

@VoyTechnology why the need to want this migrated? We haven't even been able to make the terra-farm organisation a place for providers to see the light and have shared maintainership. I doubt moving this to Hashicorp would bring us anything additional.

VoyTechnology commented 5 years ago

Misread https://github.com/terra-farm/terraform-provider-virtualbox/issues/48#issuecomment-456199009. Replaced terra-farm with terraform-providers in my head.

But I think the TODO list still holds overall for v1.0 release.

VoyTechnology commented 5 years ago

Feel free to close this issue if you think this is unnecessary

ringods commented 5 years ago

@VoyTechnology true regarding the todo list. Can you update this issue by:

VoyTechnology commented 5 years ago

Updated the comment. Please let me know which of the points from https://github.com/terra-farm/terraform-provider-virtualbox/issues/50#issuecomment-456506855 I should add to the TODO list.

ringods commented 5 years ago

@VoyTechnology I updated the Terraform build dependency to v0.12.0. Needs some manual testing before we release a first provider version for TF 0.12.

ringods commented 5 years ago

@VoyTechnology I suggest we decouple the versioning towards v1 from the compatibility with TF 0.12. I can release a TF 0.12 compatible version shortly, but the provider lacks too much regarding datasources and/or resources that I would already like to make it a v1.

OK if I create a release for TF 0.12 where users can file bugs against? From there, we can augment the provider to make a V1 ready.

Comments?

VoyTechnology commented 5 years ago

Makes sense, since TF 0.12 is already out. I think we should have some release ASAP.

ringods commented 5 years ago

@VoyTechnology the TF 0.12 compatible version is here:

https://github.com/terra-farm/terraform-provider-virtualbox/releases/tag/v0.2.0

VoyTechnology commented 2 years ago

Because the v1.0 is a bit ambiguous, for the time being I have split it into 2 releases which will come before this:

This split allows to prioritise. This doesn't mean that the networking is less important than storage, but it just gives some notion of a goal.