search

terra-farm / terraform-provider-virtualbox

VirtualBox provider for Terraform
https://terra-farm.github.io/provider-virtualbox/
MIT License
324 stars 136 forks source link

import go-virtualbox #54

Closed catay closed 5 years ago

catay commented 5 years ago

Hi,

Is there a reason why the provider imports 'github.com/pyToshka/go-virtualbox' and not 'github.com/terra-farm/go-virtualbox' ?
The latest seems to be maintained and also contains a proper license.

Happy to submit a PR to get that changed if that makes sense.

Cheers.

VoyTechnology commented 5 years ago

It was left out a long time ago and forgotten about. I don't think there is any reason why not to use it. I was planning a long time ago to rewrite the package to talk directly using Virtualbox SDK, but the Go API would stay the same (or at least be semver'ed). So feel free to create a PR.

ringods commented 5 years ago

@VoyTechnology I'm not in favor of using the Virtualbox SDK. The SDK is COM based, which is old technology and not very easy to find documentation for. I'm also not sure if this works equally wel on all platforms. Personally, I'm more in favor of improving the integration via VBoxManage. However, let's discuss that in the go-virtualbox issue tracker. ;-)

VoyTechnology commented 5 years ago

Resolved by #55