Harmonize the unboundings because at the moment we have unbondings and undelegations. Technically when we talk about undelegation it is an unbound. I would recommend to create a naming definition that talks about:
BeginUnbonding: when the unbond action is requested by the user (e.g method name Undelegate should be BeginUnbonding,
CompleteUnbond: when the action of transferring the tokens from the x/alliance account to the user account happens (e.g. the method CompleteUndelegations must be renamed to CompleteUnbond.
there are more places in the code where this modifications need to be applied but these were just two of the many examples where the wording should be changed from undelegation to unbonding
Is important to take in consideration that the old entry points with the undelegations name must remain the same as now but must be deprecated, that way can be removed in a future release.
Harmonize the
unboundings
because at the moment we haveunbondings
andundelegations
. Technically when we talk aboutundelegation
it is anunbound
. I would recommend to create a naming definition that talks about:BeginUnbonding
: when the unbond action is requested by the user (e.g method name Undelegate should be BeginUnbonding,CompleteUnbond
: when the action of transferring the tokens from the x/alliance account to the user account happens (e.g. the method CompleteUndelegations must be renamed to CompleteUnbond.Is important to take in consideration that the old entry points with the
undelegations
name must remain the same as now but must be deprecated, that way can be removed in a future release.