search

terra-money / docs

🗂 The official documentation for the Terra blockchain
https://docs.terra.money
Other
124 stars 203 forks source link

fix: naming in cw20 token factory tutorial #491

Closed llllllluc closed 2 years ago

llllllluc commented 2 years ago
  1. config.terrain.json is the name generated by terrain, but the cw20 tutorial used terrain.config.json, either the doc is wrong or terrain is wrong. Just wanna raise awareness.
  2. cw20_factory_token is named as cw20-factory-token in crates.io, maybe we should change all naming to cw20-factory-token in the tutorial when creating this new contract.
llllllluc commented 2 years ago

👍🏼

Thanks! Looks like there's something wrong with the CI flow. Not sure if it's caused by me.

llllllluc commented 2 years ago

👍🏼

Thanks! Looks like there's something wrong with the CI flow. Not sure if it's caused by me.

Merge will be unblocked after 492 is merged.

terran6 commented 2 years ago

👍🏼

Thanks! Looks like there's something wrong with the CI flow. Not sure if it's caused by me.

Merge will be unblocked after 492 is merged.

Yup! We will get to that PR tomorrow and then merge yours in after that. Thanks for the update! 😄

llllllluc commented 2 years ago

close this one and use 493 instead as that includes a unit test fix as well.