search

terra-ops / terra-cli

The Terra Command Line Interface
http://terra.readthedocs.org
GNU General Public License v2.0
48 stars 17 forks source link

Code style? #15

Closed xendk closed 9 years ago

xendk commented 9 years ago

Terra seems to be using mostly Drupal Coding Standard style. Considering it's more of a Symfony Command project, can I suggest using PSR-2 instead?

jonpugh commented 9 years ago

:+1: on this one.

jmolivas commented 9 years ago

I will take care of making the code base PSR-2 code style compliant and provide a PHP Class and a pre-commit hook to execute when trying to commit code to the project.

jmolivas commented 9 years ago

Since the PR https://github.com/terra-ops/terra-app/pull/45 was merged

1) Should this be closed?

2) Wait for this:

I am planing to send a new PR containing this https://github.com/hechoendrupal/DrupalConsole/blob/master/CodeQualityTool.php

And also instructions how to add it to your pre-commit git-hook in order to check code before sneding a commit.