search

terra-sync / cnc

Seamless Database Replication tool
GNU General Public License v3.0
4 stars 2 forks source link

Multiple same-type database functionality #73

Open panosfol opened 5 months ago

panosfol commented 5 months ago

Closes #63

panosfol commented 5 months ago

Convert to draft since there are a few errors indicated by valgind/helgrind. Waiting for input from @charmitro .

charmitro commented 4 months ago

I'm getting weird helgrind output when running with email enabled, can you enable it properly (actually send an email) and see hellgrind's output?

panosfol commented 4 months ago

I'm getting weird helgrind output when running with email enabled, can you enable it properly (actually send an email) and see hellgrind's output?

Yes there are actually a lot of errors, all of them from the rust module. Also the actually sending of the email does not always happen for all the databases that were replicated, indicating that there is a conflict on the threads, making the outcome unpredictable.

charmitro commented 4 months ago

I'm getting weird helgrind output when running with email enabled, can you enable it properly (actually send an email) and see hellgrind's output?

Yes there are actually a lot of errors, all of them from the rust module. Also the actually sending of the email does not always happen for all the databases that were replicated, indicating that there is a conflict on the threads, making the outcome unpredictable.

How should we handle this?

  1. Should we postpone the merging of this PR until fixed?
  2. Disable email for more than one databases defined in the config?
panosfol commented 4 months ago

I'm getting weird helgrind output when running with email enabled, can you enable it properly (actually send an email) and see hellgrind's output?

Yes there are actually a lot of errors, all of them from the rust module. Also the actually sending of the email does not always happen for all the databases that were replicated, indicating that there is a conflict on the threads, making the outcome unpredictable.

How should we handle this?

  1. Should we postpone the merging of this PR until fixed?
  2. Disable email for more than one databases defined in the config?

Lets postpone merging this, and look into multithreading in the rust library. Also we probably should create a seperate issue for this, since its about the rust library. I'll branch off of this branch and start looking into it.

panosfol commented 4 months ago

Issues #74 and #75 should first be resolved before we move forward with merging this PR.