terracotta-bank / terracotta-bank

An intentionally-vulnerable web application, ported from https://github.com/jzheaux/terracotta-bank-spring
Apache License 2.0
38 stars 32 forks source link

Consider converting servlets into Spring MVC Controllers #9

Open jzheaux opened 6 years ago

jzheaux commented 6 years ago

Controllers are a bit more familiar these days, and it may be helpful to favor them in the app since we are already using Spring Boot.

By converting over to controllers it will also be simpler to use tools like MockMvc to simplify some of the unit tests Terracotta uses to demonstrate vulnerabilities.

tummala commented 6 years ago

Yes, using Spring controllers are configured via IOC like any other objects. This makes them easy to test and integrate with other objects.