terraform-aviatrix-modules / terraform-aviatrix-mc-overlap-nat-spoke

This configures Aviatrix spoke gateways to deal with IP overlap in the spoke VNET/VPC by adding NAT rules and route propagation
Apache License 2.0
0 stars 6 forks source link

Updated module for 7.1 compatibility #7

Closed alexandreweiss closed 1 year ago

alexandreweiss commented 1 year ago

Hi Dennis,

I was using this module and upgraded the target controller to 7.1 so it needed some version update. Can you double check the TF provider version>=0.3.1 as i'm not sure about this one. (It doesn't match the real version number 3.1.0) I tested the module to apply DNAT/SNAT using my branch and worked fine. No other advanced tests.

Thanks !

Dennizz commented 1 year ago

There's really no reason to bump the docs. The bigger than or equal constraint fulfills the compatibility here.

=7.0 matches 7.0, 7.1 or 53.99 for that matter. Same for the provider.

The provider versioning is a bit different than in most modules, due to the leading 0. But that shouldn't be to challenging I believe.