search

terraform-aws-modules / terraform-aws-acm

Terraform module to create AWS ACM resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/acm/aws
Apache License 2.0
182 stars 229 forks source link

Add --domain-validation-options support #105

Closed philicious closed 2 years ago

philicious commented 2 years ago

Is your request related to a new offering from ~AWS~ terraform-provider-aws?

Is your request related to a problem? Please describe.

The ACM-request option --domain-validation-options ValidationDomain=bar.com,DomainName="foo.bar.com" for modifying the domain used for sending the validation email to, couldnt be used yet as the TF-provider didnt support it. Finally, after only 4yrs being open, the PR got merged and its available in provider 4.12.0

Describe the solution you'd like.

Now this module only needs to add a new variable and adynamic validation_option block to pass it on in resource "aws_acm_certificate"

I'll see if I get to opening a PR this weekend, but wanted to open an issue just in case I dont

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 2 years ago

This issue was automatically closed because of stale in 10 days

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.