terraform-aws-modules / terraform-aws-acm

Terraform module to create AWS ACM resources πŸ‡ΊπŸ‡¦
https://registry.terraform.io/modules/terraform-aws-modules/acm/aws
Apache License 2.0
184 stars 230 forks source link

Allow specifying an alternative provider for dns records #111

Closed njoerd114 closed 2 years ago

njoerd114 commented 2 years ago

Is your request related to a new offering from AWS?

Is your request related to a problem? Please describe.

We're managing our DNS Zones in a separate AWS Account. We'd like to use this module to provision ACM Certificates for products in their accounts.

Describe the solution you'd like.

Add the option to specify an additional provider (defaults to the default provider).

Describe alternatives you've considered.

One could also specify the validation records separately and not use this functionality from the module, however that would result in some overhead.

Additional context

Module Provider Docs

njoerd114 commented 2 years ago

108 actually seams to achieve this...

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

dannyibishev commented 2 years ago

108 actually seams to achieve this...

I've been using the forked repo I created for the above in a number of project and it works without issue. Sadly it's been two months and I've still not heard anything from the module Code owners. :'(

MrKoopaKiller commented 2 years ago

+1

dhoppe commented 2 years ago

@njoerd114 I understand your use case, but I do not think it is the responsibility of a Terraform module to support different AWS accounts.

For example, the subdomain in account A could point to the nameservers of account B's hosted zone.

Another possibility would be to use Terragrunt or Terramate.

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

dannyibishev commented 2 years ago

114 Closes this issue. Thanks Anton πŸ₯‡

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.