search

terraform-aws-modules / terraform-aws-acm

Terraform module to create AWS ACM resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/acm/aws
Apache License 2.0
182 stars 229 forks source link

fix: Correct `validation_option` variable type #112

Closed philicious closed 2 years ago

philicious commented 2 years ago

Description

in #106 we managed to merge non-working code, I am afraid. A suggestion by @bryantbiggs changed the map(object..) to a map(string) which I applied. however it needs to be a map(any) It probably went unnoticed when @antonbabenko tested the example as he used a version that hadnt the suggestion applied yet.

Motivation and Context

using v4.0 results in 

module "acm" {
  source  = "terraform-aws-modules/acm/aws"
  version = "~> v4.0"

  validation_option = {
    "default" = {
      domain_name = var.domain_name
      validation_domain = var.validation_domain
    }
  }
The given value is not suitable for child module variable "validation_option" defined at .terraform/modules/dns.acm/variables.tf:54,1-29: element "default": string required.

when changing the variable type, TF shows a diff as expected

antonbabenko commented 2 years ago

This PR is included in version 4.0.1 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.