Closed edgarsandi closed 1 year ago
all of the versions will need to be updated to reflect the version that this attribute was added in (4.40.0) https://github.com/terraform-aws-modules/terraform-aws-acm/blob/8a0e0b66e30fe011facebac2f3288e9dc23d51d5/versions.tf#L7
This PR is included in version 4.3.0 :tada:
Hi, this PR is maybe related to my issue ? I'm in version 4.3.0
and the key_algorithm is present indeed.
Reverting on version 4.2.0 works fine π
what version AWS provider are you using?
https://github.com/terraform-aws-modules/terraform-aws-acm/pull/125#issuecomment-1336437077
me too.
We are using 4.39.0
.
provider "registry.terraform.io/hashicorp/aws" {
version = "4.39.0"
constraints = ">= 2.53.0, >= 3.30.0, >= 3.56.0, >= 3.73.0, >= 4.0.0, ~> 4.0, >= 4.12.0, >= 4.30.0"
hashes = [
"h1:5jIAzI33opxKT6TFoAP/UVvRKvtpDe7Dsaw20go3U7w=",
....
"zh:f68b2685ee86bcf314d74a20e97b5cbe0c63741827143f7a4ba7ec56555329dc",
]
}
it looks like the root version was not updated like the rest of the versions - should be resolved in #126
@bryantbiggs Agreed. https://github.com/hashicorp/terraform-provider-aws/pull/27781 shows that key_algorithm of aws_acm_certificate needs 4.40.
I'm going to lock this pull request because it has been closed for 30 days β³. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
Description
Motivation and Context
In the version 4.40.0 of the terraform-provider-aws was added support to set the
key algorithm
This PR adds the support to this argument in the
terraform-aws-acm
module.Breaking Changes
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request