terraform-aws-modules / terraform-aws-acm

Terraform module to create AWS ACM resources πŸ‡ΊπŸ‡¦
https://registry.terraform.io/modules/terraform-aws-modules/acm/aws
Apache License 2.0
181 stars 228 forks source link

Ability to support multiple hostnames and DNS zones #136

Closed rapides closed 1 week ago

rapides commented 1 year ago

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

Is your request related to a problem? Please describe.

I cannot select more zone_id when I want to support more than one DNS name with totally different hostnames. In order to create CloudFront distribution that uses 2 totally different domains at the same time (example: example.com and example.co) and I need to use a single SSL certificate that whitelists 2 different hostnames. In such cases, each domain has to have a separate DNS zone.

Describe the solution you'd like.

Ability to enter domains and zones together via a single variable, so you can easily distinguish when you need to create DNS records in separate DNS zones.

Describe alternatives you've considered.

N/A

Additional context

amontalban commented 11 months ago

We are having the same need, would be great to genera an ACM certificate with multiple domains so we don't have to create multiple CloudFront distributions.

amontalban commented 11 months ago

@rapides can you try #137 and see if that works for you? Thanks!

github-actions[bot] commented 10 months ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

phuhl commented 10 months ago

I have the same issue

github-actions[bot] commented 9 months ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

phuhl commented 9 months ago

Issue still perists

github-actions[bot] commented 8 months ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

phuhl commented 8 months ago

Issue still perists

github-actions[bot] commented 7 months ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

phuhl commented 7 months ago

Issue still perists

antonbabenko commented 6 months ago

https://github.com/terraform-aws-modules/terraform-aws-acm/pull/137#pullrequestreview-1662067778 - my review is still relevant and someone can take it further and work on improvements.

alemarmed commented 6 months ago

Hi @amontalban, do you intend to resume #137? Otherwise I think I could make requested changes.

github-actions[bot] commented 5 months ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

phuhl commented 5 months ago

Issue still perists, I don't know the code in here at all, so I am not sure, it makes sense for me to work on this, but @amontalban maybe you could create a new PR based on #137?

github-actions[bot] commented 4 months ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

phuhl commented 4 months ago

Issue still persists, waiting for https://github.com/terraform-aws-modules/terraform-aws-acm/pull/149

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

phuhl commented 3 months ago

Issue still persists, waiting for https://github.com/terraform-aws-modules/terraform-aws-acm/pull/149

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

phuhl commented 2 months ago

Issue still persists, waiting for https://github.com/terraform-aws-modules/terraform-aws-acm/pull/149

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

phuhl commented 1 month ago

Issue still persists, waiting for https://github.com/terraform-aws-modules/terraform-aws-acm/pull/149

github-actions[bot] commented 1 week ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

phuhl commented 1 week ago

Issue still persists, waiting for https://github.com/terraform-aws-modules/terraform-aws-acm/pull/149

antonbabenko commented 1 week ago

@phuhl it's your turn to check it out and open an issue if you see something wrong. I'm sorry it took so long to get this one reviewed and merged.

phuhl commented 1 week ago

Thank you for putting the work in :)