search

terraform-aws-modules / terraform-aws-acm

Terraform module to create AWS ACM resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/acm/aws
Apache License 2.0
184 stars 230 forks source link

feat: Allow multiple domains in one cert #137

Closed amontalban closed 10 months ago

amontalban commented 1 year ago

Description

This PR allows creating one ACM certificate for multiple domains, which, is useful when using the certificate for CloudFront that only allows one certificate per distribution.

Motivation and Context

CloudFront does not support multiple ACM certificates, like ALB. Therefore, if you need to support multiple domains in a single CloudFront distribution you would have to create the certificate manually because this module does not support it.

Breaking Changes

This change should be backward compatible as I added a zones var containing a map with domains and their Route53 zone ID so the validation records are created in the correct Route53 zone.

Additionally, I have updated the tests in examples/complete-dns-validation to allow variables so it was easier for me (and others) to test with my test domains.

How Has This Been Tested?

Fixes #136

amontalban commented 1 year ago

@antonbabenko Do you think this is good to be merged? I have tested with my use case but I don't have access to the zones/domains that are described in the test cases so cannot fully validate it is a breaking change or not.

Thank you!

vishwa-trulioo commented 12 months ago

Any update on this merge?

bryantbiggs commented 12 months ago

changes have been requested but not implemented as shown above, so it won't be merged until resolved

github-actions[bot] commented 11 months ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] commented 10 months ago

This PR was automatically closed because of stale in 10 days

github-actions[bot] commented 9 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.