search

terraform-aws-modules / terraform-aws-acm

Terraform module to create AWS ACM resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/acm/aws
Apache License 2.0
182 stars 229 forks source link

Revert BB change, make it backwards compatible #139

Closed cypher7682 closed 11 months ago

cypher7682 commented 11 months ago

Description

Reverts a breaking change.

Motivation and Context

It makes it not a breaking change

Breaking Changes

It reverts a breaking change.

How Has This Been Tested?

It hasn't. It's for illustrative purposes / comment.

cypher7682 commented 11 months ago

This is relevant to #135

I've tested it my end, and it seems to work fine. But definitely worth someone else giving it a once over as I don't have private certs to import and test the NONE functionality through and through. The logic on the counts seems to work as expected though, and the certificate deploys.

DNS functionality also remains working.

charlierm commented 11 months ago

This looks great @cypher7682 , looks like the semantic pr title is failing then hopefully good to go!

antonbabenko commented 11 months ago

This issue has been resolved in version 5.0.0 :tada:

github-actions[bot] commented 10 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.